Schema fields with underscore

[rodrigo-brito]

When we generate a schema with underscore within field names, the gqlgen is including it as resolver.

Expected Behaviour

Generate a field in User model with name MyNumber and type *int`.

Actual Behavior

type userResolver struct{ *Resolver }

func (r *userResolver) MyNumber(ctx context.Context, obj *User) (*int, error) {
	panic("not implemented")
}

Minimal graphql.schema and models to reproduce

type Query {
	user(): User
}

type User {
	my_number: Int
}

[rodrigo-brito]

I inspect the generator code and check some outputs. I notice that the field GoFieldName is empty on final step, maybe it was lost during the validation process, I don't found where it happened.

codegen.(*Field).ShortResolverDeclaration

GQLName: "my_number",
GoFieldType:    0,
GoReceiverName: "",
GoFieldName:    "",

[mathewbyrne]

@rodrigo-brito thanks for the report. Can I ask, did you let gqlgen generate you a model, or did you provide your own User struct? It looks like regardless, the generated resolver does remove the underscores from the method name, so we should at least make an attempt to match to a user struct.

[rodrigo-brito]

No, I used this simple example in the unit test of generator. The GQLGen example doesn't has a target model. But it happens in both of cases.

[rodrigo-brito]

@mathewbyrne I tried to debug it yesterday, but I don't found where it was checked. I will try to open a PR today, do you have some suspect about the issue?

I notice that fields settings on gqlgen.yml solves the problem when the name was informed directly. Ex:

User:
    model: github.com/foo/bar/models.User
    fields:
      my_number:
        fieldName: MyNumber