Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests taking graphql.Upload encounter strict form field order check #2222

Closed
powerfooI opened this issue May 30, 2022 · 2 comments
Closed

Comments

@powerfooI
Copy link

What happened?

Encounter form field sequence error when parsing graphql.Upload requests from frontend, it said "first part must be operations" and "second part must be map" etc.

What did you expect?

Is it necessary to strictly check the order of form field? It would be better by checking their existence only, like before.
This form field Order Check feature was introduce by PR #2135.

Minimal graphql.schema and models to reproduce

versions

  • go run github.com/99designs/gqlgen 0.17.6
  • go version 1.18
@frederikhors
Copy link
Collaborator

Post a repo for reproduction please.

@powerfooI
Copy link
Author

I'm sorry for opening an issue for this. I found the Spec just now, the form fields are required to be ordered by design. gqlgen above v0.17.6 begins to check form fields' order. Perhaps some demonstrations about the order should be supplemented to the File Upload section in Docs.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants