Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@key on interface panics #1955

Closed
carldunham opened this issue Feb 8, 2022 · 0 comments · Fixed by #1956
Closed

@key on interface panics #1955

carldunham opened this issue Feb 8, 2022 · 0 comments · Fixed by #1956

Comments

@carldunham
Copy link
Contributor

What happened?

When adding @key to interface in federation, gqlgen run panics.

The Apollo Federation 1 spec allows this, but it isn't clear what, if anything, gqlgen should do with it. A change between 0.14.0 and 0.16.0 introduced a panic to make it explicit that this wasn't supported. However, it may be benign, and need only warn.

What did you expect?

Silently ignore the @key directive.

Minimal graphql.schema and models to reproduce

extend interface Hello @key(fields: "name") {
name: String!
secondary: String!
}

versions

  • gqlgen version? 0.16.0
  • go version? 1.17
  • dep or go modules? mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant