Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tighten up dependencies #1605

Closed
tmc opened this issue Sep 8, 2021 · 1 comment · Fixed by #1607
Closed

tighten up dependencies #1605

tmc opened this issue Sep 8, 2021 · 1 comment · Fixed by #1607

Comments

@tmc
Copy link
Contributor

tmc commented Sep 8, 2021 •
edited
Loading

It's unsuprirsing that folks would vendor the gqlgen binary but today that brings in a good deal of transitive dependencies including appdash via the chat server example.

Could the example code be moved to another repository or have it's own go.mod files created to clean up the top level dependencies of gqlgen? Thanks.
@tmc tmc changed the title tighten up depdendencies tighten up dependencies Sep 8, 2021
@lwc lwc mentioned this issue Sep 8, 2021
Merged
@lwc lwc closed this as completed in #1607 Sep 13, 2021
@tmc
Copy link
Contributor Author

tmc commented Sep 13, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[POC/RFC] Split examples into separate go module 99designs/gqlgen
1 participant
@tmc