Null doesn't propagate up to non-null list with field resolver

[ktsymbal]

What happened?

When a resolver of a non-null field in a type that is used in a null-null list of non-null elements returns null, null doesn't propagate up to the list, and then to data, but returns a null element in a list.

Example when Image(ctx context.Context, obj *Post) (*Image, error) returns nil, fmt.Errorf("error message")

{
  "errors": [
    {
      "message": "error message",
      "path": [
        "users",
        0,
        "posts",
        0,
        "image"
      ]
    }
  ],
  "data": {
    "users": [
      {
        "name": "Nate",
        "posts": [
          null
        ]
      }
    ]
  }
}

What did you expect?

According to the spec, null should be propagated up to the first nullable field.

With this example:

{
  "errors": [
    {
      "message": "error message",
      "path": [
        "users",
        0,
        "posts",
        0,
        "image"
      ]
    }
  ],
  "data": null
}

Minimal graphql.schema and models to reproduce

type User {
        name: String!
        posts: [Post!]!
}

type Post {
        title: String!
        image: Image! @goField(forceResolver: true)
}

type Image {
        name: String!
}

type Query {
        users: [User!]!
}

directive @goField(forceResolver: Boolean, name: String) on INPUT_FIELD_DEFINITION
    | FIELD_DEFINITION

versions

• gqlgen version?
  v0.11.3
• go version?
  v1.14.3
• dep or go modules?
  go modules

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[bofia]

Not stale, seems like a open bug still

[TuringJest]

This has good potential to break frontends. Has this already been fixed?

Edit: just upgraded to v0.14.0 and it's fixed now!