Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace counterfeiter package with gomock for mocking #79

Closed
oleksmir opened this issue Apr 3, 2020 · 0 comments
Closed

Replace counterfeiter package with gomock for mocking #79

oleksmir opened this issue Apr 3, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@oleksmir
Copy link
Contributor

oleksmir commented Apr 3, 2020

The counterfeiter library we use for mocks has a well-known issue about cyclic imports for public interfaces. That leads you to use private interfaces which is not very good for component decoupling.

Despite the fact that counterfeiter is a good tool for mocking, the described bug above makes this tool unusable.

I think using [gomock] is a better choice. It is an official package provided by golang community which does not have problems with mock creation for public interfaces.

@oleksmir oleksmir added good first issue Good for newcomers enhancement New feature or request labels Apr 3, 2020
@oleksmir oleksmir closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant