Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix key-value fired duplicated events in case of multi subscribers #104

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

giangndm
Copy link
Contributor

This PR fix KeyValue service bug which fired multi events when have some subscribers in same Key

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2166ec7) 87.32% compared to head (a4d0dd9) 87.77%.

Files Patch % Lines
packages/integration_tests/src/key_value.rs 88.37% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   87.32%   87.77%   +0.44%     
==========================================
  Files         116      117       +1     
  Lines       12917    12986      +69     
==========================================
+ Hits        11280    11398     +118     
+ Misses       1637     1588      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review December 28, 2023 04:16
@giangndm giangndm merged commit 5a01a4e into 8xFF:master Dec 28, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant