Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: restart-ice must route to other server in case media-node stopped #383

Open
giangndm opened this issue Jul 25, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@giangndm
Copy link
Contributor

According to bellow code, it is in TODO

async fn webrtc_restart_ice(
&self,
conn_part: Option<(NodeId, u64)>,
conn: ClusterConnId,
ip: IpAddr,
user_agent: String,
req: ConnectRequest,
userdata: Option<String>,
record: bool,
) -> RpcResult<(ClusterConnId, ConnectResponse)> {
//TODO how to handle media-node down?
if let Some((node, _session)) = conn_part {
let rpc_req = media_server_protocol::protobuf::cluster_gateway::WebrtcRestartIceRequest {
conn: conn.to_string(),
ip: ip.to_string(),
user_agent,
req: Some(req),
record,
userdata,
};
log::info!("[Gateway] selected node {node}");
let sock_addr = node_vnet_addr(node, GATEWAY_RPC_PORT);

@giangndm giangndm added the bug Something isn't working label Jul 25, 2024
@giangndm giangndm changed the title Bug: restart-ice must route to other server in case media-node stopped bug: restart-ice must route to other server in case media-node stopped Jul 31, 2024
@giangndm giangndm self-assigned this Aug 7, 2024
@jibon57
Copy link
Contributor

jibon57 commented Aug 9, 2024

restart-ice not working in firefox. always giving error:
image

very easy to reproduce. enter to the link: https://atm0s-media-sdk-samples.vercel.app/ts_samples/echo_restart_ice from firefox connect > restart ice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants