Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: checker to verify before room creation #378

Open
jibon57 opened this issue Jul 23, 2024 · 4 comments · May be fixed by #423
Open

feat: checker to verify before room creation #378

jibon57 opened this issue Jul 23, 2024 · 4 comments · May be fixed by #423
Assignees

Comments

@jibon57
Copy link
Contributor

jibon57 commented Jul 23, 2024

Issue Template

Description

As we discussed in discord regarding this. I'm just adding it here.

https://discord.com/channels/1173844241542287482/1173844241542287485/1264884109574934569

Steps to Reproduce

  1. Step 1
  2. Step 2
  3. Step 3

Expected Behavior

Please describe what you expected to happen.

Actual Behavior

Please describe what actually happened.

Screenshots

If applicable, add screenshots to help explain the issue.

Environment

  • Operating System:
  • Browser (if applicable):
  • Version (if applicable):

Additional Information

Add any other relevant information about the issue here.

@giangndm
Copy link
Contributor

giangndm commented Jul 24, 2024

Just note some idea:

  • Setting a token check endpoint (from config or when create token)
  • Media server call check endpoint for ensuring it valid

Some concerns:

  • How to config it?
  • If embedded inside token, it can make token too big

@jibon57
Copy link
Contributor Author

jibon57 commented Jul 24, 2024

@giangndm thank you.

How to config it?

I think it should be set from server level config. Most of the time it will be a fixed URL.

@giangndm
Copy link
Contributor

@giangndm thank you.

How to config it?

I think it should be set from server level config. Most of the time it will be a fixed URL.

But we have multiple zones with multiple media servers. Do you think it makes us more likely to misconfigure some servers?

@jibon57
Copy link
Contributor Author

jibon57 commented Jul 24, 2024

In this case setting up in token will be better idea. Also user will aware of if they want to use this feature & need to make sure that they've added in every server.

@luongngocminh luongngocminh linked a pull request Aug 21, 2024 that will close this issue
2 tasks
@luongngocminh luongngocminh linked a pull request Aug 21, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants