Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needing to customize readiness/liveness Probes #38

Closed
mhkarimi1383 opened this issue May 26, 2023 · 6 comments · Fixed by #50
Closed

Needing to customize readiness/liveness Probes #38

mhkarimi1383 opened this issue May 26, 2023 · 6 comments · Fixed by #50

Comments

@mhkarimi1383
Copy link

sometimes for debugging, etc. we need more customization
@Vad1mo
Copy link
Member

Vad1mo commented May 26, 2023

anything particular in mind?
Feel free to make a proposal and open a PR

@mhkarimi1383
Copy link
Author

I want to know what is the preferred way?
Full customization or changing some parts?

@Vad1mo
Copy link
Member

Vad1mo commented May 26, 2023

I don't know what options you have in mind?

Can you elaborate what you mean?

@mhkarimi1383
Copy link
Author

You can put the entire readiness and liveness prob objecs inside or just put some parts of that (like enabling it or not, or time related values)

@Vad1mo
Copy link
Member

Vad1mo commented May 27, 2023 •
edited
Loading

Thanks, in that case, I would like to only configure, enable/disable and the timing in the chart.

enabled should be the default option

@mhkarimi1383
Copy link
Author

I will try to do that in a PR

@davidspek davidspek mentioned this issue Aug 31, 2023
Merged
@Vad1mo Vad1mo closed this as completed in #50 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add probes and initcontainers + app upgrade pluralsh/n8n-helm-chart
2 participants
@Vad1mo @mhkarimi1383