Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material You icon packs not following dark/light themes #2599

Closed
Donnnno opened this issue Feb 15, 2024 · 2 comments
Closed

Material You icon packs not following dark/light themes #2599

Donnnno opened this issue Feb 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Donnnno
Copy link

Donnnno commented Feb 15, 2024

Describe the bug

Hi, this is an issue bothering me for a while now (as an icon pack dev), especially since Niagara is my favorite launcher to use for a while now.

I've noticed that Niagara fails to switch icon packs with different color configurations that are dependent on the system's dark and light themes.

We've tested many launchers, some of the biggest competitors, like Nova, Smart, or Hyperion do handle this correctly, you can view the test results over here: Arcticons-Team/Arcticons#1874

The test is based on four icon packs:

  • Arcticons Material You
  • Arcticons Day & Night
  • Pix Material You Light/Dark
  • Lawnicons

I know your priorities at this moment when it comes to icons is to Anycons, but don't forget to give some love to the other icon packs too :)

Thanks!

Steps to reproduce

  1. Use one Material You icon pack.
  2. Switch between dark & light mode.
  3. (nothing happens)

Does the issue also occur with other 3rd-party launchers?

Problem does occur with some launchers*

Other 3rd-party launcher(s) tested

See list above

Device name

Samsung Galaxy Ultra 22

Android version

Android 14

Screenshots / Screen recordings

  1. Niagara
Screen_Recording_20240215_204850_Niagara.Launcher_1.mp4
  1. Hyperion
Screen_Recording_20240215_204924_hyperion_1.mp4
@Donnnno Donnnno added the bug Something isn't working label Feb 15, 2024
@NiagaraSupport
Copy link
Collaborator

Thank you for the report.

Currently, we need to manually incorporate icon packs that utilize light and dark mode theming. You can find the current list of supported packs here. If you have more that should be added, please mention it here.
The ones you mentioned have already been included and should work fine within the following patches.

Best regards,

Team Niagara

@Donnnno
Copy link
Author

Donnnno commented Feb 28, 2024

Hi, thanks for the reply!
Good to know that it's a manual approach. And hopefully newer versions fix the theme switching. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants