Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible examine all tx data when we have custom decoding and UI #441

Open
tschubotz opened this issue Jul 21, 2021 · 0 comments
Open
Labels
Android ✅ Marked as done by QA on Android iOS ✅ Marked as done by QA on iOS Prio 🔥🔥🔥 Problem Problem to solve

Comments

@tschubotz
Copy link
Member

Problem summary

It's currently not possible to examine destination address, decoded tx data and raw tx data for transactions where we have custom decoding in the tx flow AND in the tx details.

Problem details

  • We have custom decoding for ERC20 txs and for settings changes. It's currently not possible to examine more tx data for those txs.
  • For txs with decoded data, it's not possible to view the raw tx data anymore to verify.
  • The above is true for the tx list as well as for the tx flow.
  • Especially in the tx flow, it's important to be able to verify as much data as possible.

Solution ideas

  • Allow users to examine raw Safe tx data (to, value, data, safeTxGas, safeTxHash etc.) for all txs on the tx details and on the review screen when initiating a tx and when signing/executing.
  • Allow users to view decoded data of a tx, if available, even for tx types where we have custom decoding also for all txs on the tx details and on the review screen when initiating a tx and when signing/executing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android ✅ Marked as done by QA on Android iOS ✅ Marked as done by QA on iOS Prio 🔥🔥🔥 Problem Problem to solve
Projects
None yet
Development

No branches or pull requests

2 participants