Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

UI breaks when sending big amounts #353

Closed
lukasschor opened this issue Dec 16, 2019 · 0 comments
Closed

UI breaks when sending big amounts #353

lukasschor opened this issue Dec 16, 2019 · 0 comments
Assignees
Labels
Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases.

Comments

@lukasschor
Copy link
Member

Bug reported by user:

I can’t see my transactions (safe website crashes) https://rinkeby.gnosis-safe.io/safes/0x94D998c2Cb35bD4388D1D5Ed71992bF4a802d7a9/transactions

"Error: [number-to-bn] while converting number "1e+27" to BN.js instance, error: invalid number value. Value must be an integer, hex string, BN or BigNumber instance. Note, decimals are not supported. Given value: "1e+27""

happens in rows -> getTxAmount -> toBN

I have a pending transaction were I send 1 billion ETH .. that seems to break the interface

maybe we could solve this by returning a string from the relay service for the value

my quick fix was tx.value.toLocaleString('fullwide', { useGrouping: false })
but this truncates some numbers (which was no issue here … just wanted by UI back )

@lukasschor lukasschor added Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases. labels Dec 16, 2019
@lukasschor lukasschor added this to the Safe for Teams v1.4.0. (Improvements & Bugfixes) milestone Dec 16, 2019
@Agupane Agupane self-assigned this Dec 16, 2019
@mmv08 mmv08 closed this as completed Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases.
Projects
None yet
Development

No branches or pull requests

3 participants