Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Hide "Hide Zero Balances" #291

Closed
lukasschor opened this issue Nov 22, 2019 · 3 comments
Closed

Hide "Hide Zero Balances" #291

lukasschor opened this issue Nov 22, 2019 · 3 comments
Assignees
Labels
Enhancement ✨ Minor Improvement / changes to existing functionality Minor Needs to be fixed within the next 1-3 public releases.

Comments

@lukasschor
Copy link
Member

Currently, the "Hide Zero Balances" checkbox holds a very prominent spot on the asset view screen. This feature should be moved to the "Manage List" screen, given that it also technically is about managing the list of assets displayed.

@lukasschor lukasschor added Enhancement ✨ Minor Improvement / changes to existing functionality Design Minor Needs to be fixed within the next 1-3 public releases. labels Nov 22, 2019
@lukasschor lukasschor modified the milestones: Safe for Teams v1.5.0 (New Year Features), Safe for Teams v1.4.0. (Improvements & Bugfixes) Nov 22, 2019
@leolower
Copy link

leolower commented Dec 3, 2019

@lukasschor hiding it from the balance tab is very easy but we are not sure what the desired behavior should be on the "manage tokens" modal.

Should this be a button that disables all tokens that have zero balance?

@lukasschor
Copy link
Member Author

True this might be confusing as the user might assume that that this somehow affects the blacklist, which it shouldn't.

To be honest, I am unsure about how much user-value this feature provides and I actually know no other wallet that has this feature in their asset list. After all, the user could just sort the list by balance descending and would get almost the same benefit.

So for the sake of keeping the product clean and focused, I would just remove the feature for now and wait and see if there is actually some user demand for it.

What do you think @leolower?

@leolower
Copy link

leolower commented Dec 3, 2019

Exactly.

IMO the token list plus auto-adding tokens with a positive balance is more than enough.
I don't think teams will add/remove tokens from the list all that often so the additional functionality of having tokens enabled but hiding them when they have zero balance is a bit redundant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement ✨ Minor Improvement / changes to existing functionality Minor Needs to be fixed within the next 1-3 public releases.
Projects
None yet
Development

No branches or pull requests

3 participants