Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Set safeTxGas=0 for rejections #1978

Closed
tschubotz opened this issue Mar 2, 2021 · 0 comments · Fixed by #1993
Closed

Set safeTxGas=0 for rejections #1978

tschubotz opened this issue Mar 2, 2021 · 0 comments · Fixed by #1993
Assignees
Labels
Feature 👑 New functionality

Comments

@tschubotz
Copy link
Member

What is this feature about? (1 sentence)

This sets safeTxGas to 0 for on-chain rejections in order to be in line with mobile apps and client gateway.

Why is it needed? What is the value? For whom do we build it?

  • On-chain rejections are Safe txs to the Safe itself with data set to 0x/null
  • Currently, we still estimates safeTxGas properly and uses that value.
  • That means that currently many different on-chain rejections can be created as long as they use different safeTxGas value.
  • With "Proper rejections" we wanted to streamline that by setting all params, including safeTxGas to 0x/null/0.
  • That way, only 1 type of on-chain rejection can be created for a given nonce (Since the safeTxHash would be the same always).
  • Currently mobile and web create different types of on-chain rejections which is a challenge for the client gateway and UX.

High-level overview of the feature

  • When creating rejections, set safeTxGas to 0 instead of doing gas estimation for it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature 👑 New functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants