You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
We currently addressed the issue that affected transactions pending that have the same nonce. This can be a handful use case for some teams that want to overwrite a transaction they don't want to execute anymore.
After this change some inconsistencies are left that require further refactor. If two transactions with the same nonce are created and one of them gets a reject signature, this reject signature will be shown in both transactions. This happens because cancel transactions are related using the nonce instead of txHash, so the interface is not able to distinguish correctly which is the correct transaction.
We should check all the places where we relate transactions by nonce in order to prevent behaviors like this
The text was updated successfully, but these errors were encountered:
dasanra
added
Bug 🐛
Something isn't working
Critical
Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped.
labels
Oct 16, 2020
If two transactions with the same nonce are created and one of them gets a reject signature, this reject signature will be shown in both transactions
This is expected behaviour for me right now
dasanra
added
Major
Needs to be fixed for immediate next public release.
and removed
Critical
Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped.
labels
Oct 16, 2020
tschubotz
added
Minor
Needs to be fixed within the next 1-3 public releases.
and removed
Major
Needs to be fixed for immediate next public release.
labels
Nov 25, 2020
We currently addressed the issue that affected transactions pending that have the same nonce. This can be a handful use case for some teams that want to overwrite a transaction they don't want to execute anymore.
After this change some inconsistencies are left that require further refactor. If two transactions with the same nonce are created and one of them gets a reject signature, this reject signature will be shown in both transactions. This happens because cancel transactions are related using the nonce instead of txHash, so the interface is not able to distinguish correctly which is the correct transaction.
We should check all the places where we relate transactions by nonce in order to prevent behaviors like this
The text was updated successfully, but these errors were encountered: