Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Reject inconsistency in transactions with same nonce #1485

Closed
dasanra opened this issue Oct 16, 2020 · 2 comments
Closed

Reject inconsistency in transactions with same nonce #1485

dasanra opened this issue Oct 16, 2020 · 2 comments
Labels
Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases.

Comments

@dasanra
Copy link
Collaborator

dasanra commented Oct 16, 2020

We currently addressed the issue that affected transactions pending that have the same nonce. This can be a handful use case for some teams that want to overwrite a transaction they don't want to execute anymore.

After this change some inconsistencies are left that require further refactor. If two transactions with the same nonce are created and one of them gets a reject signature, this reject signature will be shown in both transactions. This happens because cancel transactions are related using the nonce instead of txHash, so the interface is not able to distinguish correctly which is the correct transaction.

We should check all the places where we relate transactions by nonce in order to prevent behaviors like this

@dasanra dasanra added Bug 🐛 Something isn't working Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped. labels Oct 16, 2020
@rmeissner
Copy link
Member

If two transactions with the same nonce are created and one of them gets a reject signature, this reject signature will be shown in both transactions

This is expected behaviour for me right now

@dasanra dasanra added Major Needs to be fixed for immediate next public release. and removed Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped. labels Oct 16, 2020
@tschubotz tschubotz added Minor Needs to be fixed within the next 1-3 public releases. and removed Major Needs to be fixed for immediate next public release. labels Nov 25, 2020
@tschubotz
Copy link
Member

I think so too. Also, with #820 this should be fixed. Hence, I'd close this ticket for now. Please reopen in case there are objections.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases.
Projects
None yet
Development

No branches or pull requests

3 participants