Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: The enable cookies option for JavaScriptBuilderElement is now configurable per-request. #115

Merged
merged 4 commits into from
May 7, 2024
Merged

FEAT: The enable cookies option for JavaScriptBuilderElement is now configurable per-request. #115

merged 4 commits into from
May 7, 2024

Conversation

ben51degrees
Copy link
Contributor

Adding the query parameter fod-js-enable-cookies will override the option supplied to the element at construction.

This PR closes #109.

@ben51degrees
FEAT: The enable cookies option for JavaScriptBuilderElement is now…
6ca2917 
… configurable per-request.

Adding the query parameter `fod-js-enable-cookies` will override the option supplied to the element at construction.

This PR closes #109.
@ben51degrees
Merge remote-tracking branch 'origin/main' into feature/cookies
33c5739
@ben51degrees
BUG: Use correct include for new constants.
4dd4ba5
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Unit Tests - Ubuntu_Node_18

  1 files   17 suites   46s ⏱️
111 tests 111 ✅ 0 💤 0 ❌
115 runs  115 ✅ 0 💤 0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Integration Tests - Ubuntu_Node_18

2 tests  ±0   2 ✅ ±0   1s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4e6e148. ± Comparison against base commit d9e68e7.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Unit Tests - Ubuntu_Node_20

  1 files   17 suites   45s ⏱️
111 tests 111 ✅ 0 💤 0 ❌
115 runs  115 ✅ 0 💤 0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Unit Tests - macOS_Node_20

  1 files   17 suites   42s ⏱️
111 tests 111 ✅ 0 💤 0 ❌
115 runs  115 ✅ 0 💤 0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Unit Tests - macOS_Node_18

  1 files   17 suites   43s ⏱️
111 tests 111 ✅ 0 💤 0 ❌
115 runs  115 ✅ 0 💤 0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Performance Tests - Ubuntu_Node_18

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Integration Tests - Ubuntu_Node_20

2 tests  ±0   2 ✅ ±0   1s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4e6e148. ± Comparison against base commit d9e68e7.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Integration Tests - macOS_Node_20

2 tests  ±0   2 ✅ ±0   1s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4e6e148. ± Comparison against base commit d9e68e7.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Integration Tests - macOS_Node_18

2 tests  ±0   2 ✅ ±0   1s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4e6e148. ± Comparison against base commit d9e68e7.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Unit Tests - Windows_Node_20

  1 files   17 suites   49s ⏱️
111 tests 111 ✅ 0 💤 0 ❌
115 runs  115 ✅ 0 💤 0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Unit Tests - Windows_Node_18

  1 files   17 suites   48s ⏱️
111 tests 111 ✅ 0 💤 0 ❌
115 runs  115 ✅ 0 💤 0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Integration Tests - Windows_Node_20

2 tests  ±0   2 ✅ ±0   1s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4e6e148. ± Comparison against base commit d9e68e7.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Integration Tests - Windows_Node_18

2 tests  ±0   2 ✅ ±0   1s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4e6e148. ± Comparison against base commit d9e68e7.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Performance Tests - Windows_Node_20

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Performance Tests - Windows_Node_18

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

justadreamer
justadreamer reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@justadreamer justadreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ben51degrees thanks for implementing this!

Some checks are failing on CI: https://github.com/51Degrees/pipeline-node/actions/runs/8917269314/job/24490060415#step:5:258

Could you please install eslint globally on your machine and fix the errors it reports - mainly indentation and style stuff:

eslint . --ext .js

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

Performance Tests - macOS_Node_20

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

Performance Tests - Ubuntu_Node_20

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

Performance Tests - macOS_Node_18

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4e6e148.

♻️ This comment has been updated with latest results.

@Automation51D Automation51D merged commit 5af379b into main May 7, 2024
18 checks passed
@Automation51D Automation51D deleted the feature/cookies branch May 7, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justadreamer justadreamer justadreamer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Per-Detection Configuration of Enable/Disable Cookies
3 participants
@ben51degrees @justadreamer @Automation51D