reworked a way of request url parts parsing #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiftyone.pipeline.core/evidence.js
Outdated
| const protocol = request.protocol || 'http'; | ||
| const hostname = request.hostname || 'localhost'; // Use a default hostname if not available | ||
| const port = request.socket.localPort || ''; // Port may not be available in some cases | ||
| const searchParams = request.query || ''; // Assuming query parameters are in req.query |
There was a problem hiding this comment.
Is request an IncomingMessage type? If so it will have the .url property that can then be parsed... and then searchParams can be taken from url.URL(request.url).searchParams according to the docs.. so the previous implementation seems to have been correct...
|
|
||
| const query = params.searchParams; | ||
| const URL = new url.URL(fullURL); | ||
| const query = URL.searchParams; |
There was a problem hiding this comment.
can we have some tests directly in this package that would check that the evidence is correctly parsed from query params?
additional test check for addFromRequest added
justadreamer
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.