Pre-compute node indices to greatly improve performance. #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for publishing this add-on. When I first tried it, I thought it had crashed as the UI became unresponsive for 5-10 minutes.
Looking at the code, I noticed a similar pattern:
By itself, this isn't too expensive a computation. However, it was being recreated several times in each
for
loop. On my not too complex model, this was computed 250,000+ times.Since we only really need to do this once, creating a dictionary of:
ahead of time, allows the export to run < 1 second.
I tested the output jbeam file with
md5sum
and the outputs were equivalent.Note - This assumes that
node.id_
is unique. I.e this will return different values if they are not unique: