Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bilinear kernel is wrong? #21

Open
jszgz opened this issue May 28, 2020 · 3 comments
Open

bilinear kernel is wrong? #21

jszgz opened this issue May 28, 2020 · 3 comments

Comments

@jszgz
Copy link

jszgz commented May 28, 2020

        g_lt = (1 + (q_lt[..., :N].type_as(p) - p[..., :N])) * (1 + (q_lt[..., N:].type_as(p) - p[..., N:]))
        g_rb = (1 - (q_rb[..., :N].type_as(p) - p[..., :N])) * (1 - (q_rb[..., N:].type_as(p) - p[..., N:]))
        g_lb = (1 + (q_lb[..., :N].type_as(p) - p[..., :N])) * (1 - (q_lb[..., N:].type_as(p) - p[..., N:]))
        g_rt = (1 - (q_rt[..., :N].type_as(p) - p[..., :N])) * (1 + (q_rt[..., N:].type_as(p) - p[..., N:]))

This computation is different from standard bilinear algorithm, is it wrong or another algorithm?

@jszgz
Copy link
Author

jszgz commented May 28, 2020

image

@jszgz
Copy link
Author

jszgz commented May 28, 2020

For example, when you compute g_lt , 1 + (q_lt[..., :N].type_as(p) - p[..., :N]) is right, but 1 + (q_lt[..., N:].type_as(p) - p[..., N:]) should be 1 + ( p[..., N:] - q_lt[..., N:].type_as(p)) , which is P12(X0,y1) in my figure

@xiab3369
Copy link

It's right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants