Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: socket io v3 update #392

Merged
merged 4 commits into from
Nov 25, 2020
Merged

BREAKING CHANGE: socket io v3 update #392

merged 4 commits into from
Nov 25, 2020

Conversation

c0state
Copy link
Contributor

@c0state c0state commented Nov 23, 2020

Oops, actually, semantic release inspects npm versions it looks like. Need this PR to push the real 2.0.0 release.

Also, can we archive 1.2.1? That version is borked...

@jquense
Copy link
Member

jquense commented Nov 23, 2020

we shouldn't be bumping versions manually, the release scripts do that automatically and will probably break if the version doesn't change from their perspective

for triggering a manual release add a MANUAL_RELEASES.md that just contains the line number of manual releases: 0 then increment the number as the change

@c0state
Copy link
Contributor Author

c0state commented Nov 23, 2020

we shouldn't be bumping versions manually, the release scripts do that automatically and will probably break if the version doesn't change from their perspective

for triggering a manual release add a MANUAL_RELEASES.md that just contains the line number of manual releases: 0 then increment the number as the change

Agreed, that's a better way--changed. This should work now correct? Also, can you unpublish 1.2.1? (or should we--I think so?)

@jquense
Copy link
Member

jquense commented Nov 23, 2020

i can try and un publish it, may be that too much time has passed

@c0state
Copy link
Contributor Author

c0state commented Nov 25, 2020

This can be merged right? Unsure of convention here--was waiting on explicit approval, though I think this looks fine...

@jquense jquense merged commit 0c4ff42 into master Nov 25, 2020
@jquense jquense deleted the sliu/socketio3_build branch November 25, 2020 18:08
jquense pushed a commit that referenced this pull request Nov 25, 2020
# [2.0.0](v1.2.1...v2.0.0) (2020-11-25)

* fix!: socket io v3 update (#392) ([0c4ff42](0c4ff42)), closes [#392](#392)

### BREAKING CHANGES

* socket io v3 update

* add a manual releases file for staging manual releases

* Revert "BREAKING CHANGE: socket io v3 update"

This reverts commit 236ee12.

* linting
@jquense
Copy link
Member

jquense commented Nov 25, 2020

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants