-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: socket io v3 update #392
Conversation
we shouldn't be bumping versions manually, the release scripts do that automatically and will probably break if the version doesn't change from their perspective for triggering a manual release add a |
Agreed, that's a better way--changed. This should work now correct? Also, can you unpublish |
i can try and un publish it, may be that too much time has passed |
This can be merged right? Unsure of convention here--was waiting on explicit approval, though I think this looks fine... |
# [2.0.0](v1.2.1...v2.0.0) (2020-11-25) * fix!: socket io v3 update (#392) ([0c4ff42](0c4ff42)), closes [#392](#392) ### BREAKING CHANGES * socket io v3 update * add a manual releases file for staging manual releases * Revert "BREAKING CHANGE: socket io v3 update" This reverts commit 236ee12. * linting
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Oops, actually, semantic release inspects npm versions it looks like. Need this PR to push the real 2.0.0 release.
Also, can we archive 1.2.1? That version is borked...