fix: await credentials when subscribing #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 4, 2020 18:30
taion
approved these changes
Jun 6, 2020
taion
approved these changes
Jun 8, 2020
|
see note; the old race condition guard is no longer applicable |
added 2 commits
June 8, 2020 16:17
|
I assume this really should be a major version bump because of the interface change? Even though that feels silly for a small bug fix. |
jquense
pushed a commit
that referenced
this pull request
Jun 8, 2020
## [1.0.1](v1.0.0...v1.0.1) (2020-06-08) ### Bug Fixes * await credentials when subscribing ([#351](#351)) ([df9f3a8](df9f3a8))
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should do the trick, though tbh I'm not quite sure if this is what you were suggesting (and also whether this means a major version bump from changing the interface to
CredentialsManager).