Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: await credentials when subscribing #351

Merged
merged 6 commits into from
Jun 8, 2020
Merged

fix: await credentials when subscribing #351

merged 6 commits into from
Jun 8, 2020

Conversation

patricktemple
Copy link
Contributor

I think this should do the trick, though tbh I'm not quite sure if this is what you were suggesting (and also whether this means a major version bump from changing the interface to CredentialsManager).

Copy link
Contributor

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks right; just some nits

src/JwtCredentialsManager.ts Outdated Show resolved Hide resolved
src/JwtCredentialsManager.ts Outdated Show resolved Hide resolved
src/JwtCredentialsManager.ts Outdated Show resolved Hide resolved
src/JwtCredentialsManager.ts Outdated Show resolved Hide resolved
src/JwtCredentialsManager.ts Outdated Show resolved Hide resolved
src/JwtCredentialsManager.ts Outdated Show resolved Hide resolved
@taion
Copy link
Contributor

taion commented Jun 8, 2020

see note; the old race condition guard is no longer applicable

@patricktemple
Copy link
Contributor Author

I assume this really should be a major version bump because of the interface change? Even though that feels silly for a small bug fix.

@patricktemple patricktemple merged commit df9f3a8 into master Jun 8, 2020
@patricktemple patricktemple deleted the auth-race branch June 8, 2020 20:26
jquense pushed a commit that referenced this pull request Jun 8, 2020
## [1.0.1](v1.0.0...v1.0.1) (2020-06-08)

### Bug Fixes

* await credentials when subscribing ([#351](#351)) ([df9f3a8](df9f3a8))
@jquense
Copy link
Member

jquense commented Jun 8, 2020

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants