Fix issue #162 #163
Open
Fix issue #162 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to update it in a way which does not result in complete scrubbing of the password hashes |
Arne1303
force-pushed
the
patch-issue-162
branch
from
3e0f75a
to
a306583
Compare
|
Done, ready for review! |
|
Can this be merge? |
|
@MarceauKa Any change for this to get merged? |
|
@MarceauKa Could this be merged? That would resolve the issue of getting logged out when using the auth.session middleware :) |
|
Adding a bump here to see if we can't get this merged. |
|
I'll check that |
|
@MarceauKa sorry to bother you again. Could you take a look at this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue mentioned here, impersonation didn't work if the password hash was present in the session.