-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel Octane support #164
Comments
I can confirm this, too. |
any update on this? |
@khalidmaquilang for me logout was working with these changes |
this is good.. i hope they will merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Laravel Impersonate does not work with Laravel Octane. This manifests as several different errors concerning the
$app
container missing expected values when impersonating and leaving impersonation, from both theImpersonateManager
andImpersonateController
.I'm seeing two points where this is an issue:
ImpersonateServiceProvider
has the app container passed to the constructor. This doesn't work in the Octane paradigm -- the container is adjusted for every request, so a fresh copy is needed.register()
without that.ImpersonateController
sets themanager
property. It seems like the constructors for controllers are only called once when Octane boots, which is leading to the app container inside that manager instance being stale.If you are open to a PR, I would be happy to send one.
The text was updated successfully, but these errors were encountered: