-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ModbusMaster.cpp #98
Open
anklimov
wants to merge
9
commits into
4-20ma:master
Choose a base branch
from
anklimov:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tolerance to random noise receiving after transmission in half-duplex mode (Invalid Slave 0xE1 error preventing)
Hi @anklimov |
Hi !
In my case, I definitely saw non-zero noise values time-by time
Since the fact, correct reply always started with slave ID suggested method looks more reliable
if no appropriate SlaveID received for the response time - Timeout error will occurs
… On Jan 15, 2018, at 1:16 AM, rnicolas ***@***.***> wrote:
Hi @anklimov <https://github.com/anklimov>
I had the same problem, but the noise was always zero, so instead of comparing the readings from serial with the direction in order to know were the frame started, I just discarded all zero values until I read a non 0 value.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#98 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVhOGcbKrkWKOocazokCTR2zzGM9Dk0dks5tKnyngaJpZM4Rdud_>.
|
@anklimov |
Resolve "Bridge.cpp:121:33: error: '_crc_ccitt_update' was not declared in this scope"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tolerance to random noise receiving after transmission in half-duplex mode (Invalid Slave 0xE1 error preventing)
Awaiting for 1-s byte of response == SlaveID. All garbage before - discarding