diff --git a/.flowconfig b/.flowconfig index d99ac06fb5..581524fbcf 100644 --- a/.flowconfig +++ b/.flowconfig @@ -12,6 +12,7 @@ [lints] [options] +module.system.node.resolve_dirname=node_modules module.name_mapper.extension='scss' -> 'empty/object' module.system=haste module.name_mapper='\(Applications\|Dashboard\|LoginPage\|Navigation\|Onboarding\|Policies\|services\|Stats\|Types\|Users\|utilities\|NewService\)\(.*\)$' -> '/app/javascript/src/\1/\2' diff --git a/app/assets/stylesheets/provider/_forms.scss b/app/assets/stylesheets/provider/_forms.scss index 7317af1371..53d1863e75 100644 --- a/app/assets/stylesheets/provider/_forms.scss +++ b/app/assets/stylesheets/provider/_forms.scss @@ -1,3 +1,5 @@ +$fieldset-margin-bottom: line-height-times(1.5); + form.formtastic ol, form.formtastic ul { list-style: none; } @@ -310,7 +312,7 @@ form.formtastic { position: relative; padding: line-height-times(1) 0 0 0; border-top: $border-width solid $border-color; - margin-bottom: line-height-times(1.5); + margin-bottom: $fieldset-margin-bottom; -moz-appearance: none; -webkit-appearance: none; appearance: none; @@ -533,10 +535,14 @@ li.hidden { display: none; } -.errorMessage { - color: $error-color; -} +#new_service_wrapper { + .errorMessage { + color: $error-color; + margin-bottom: line-height-times(1/2); + margin-top: -#{$fieldset-margin-bottom}; + } -.new-service-source-input { - padding-left: line-height-times(5 / 10); + .new-service-source-input { + padding: 0 line-height-times(5 / 10); + } } diff --git a/app/controllers/provider/admin/service_discovery/cluster_projects_controller.rb b/app/controllers/provider/admin/service_discovery/cluster_projects_controller.rb index 110b659bee..479fb505ce 100644 --- a/app/controllers/provider/admin/service_discovery/cluster_projects_controller.rb +++ b/app/controllers/provider/admin/service_discovery/cluster_projects_controller.rb @@ -2,6 +2,7 @@ class Provider::Admin::ServiceDiscovery::ClusterProjectsController < Provider::Admin::ServiceDiscovery::ClusterBaseController def index - render json: { projects: cluster.projects_with_discoverables.map(&:to_json) } + render json: cluster.projects_with_discoverables.map(&:name) + .to_json end end diff --git a/app/controllers/provider/admin/service_discovery/cluster_services_controller.rb b/app/controllers/provider/admin/service_discovery/cluster_services_controller.rb index f69f23b2f5..d6d515f2b1 100644 --- a/app/controllers/provider/admin/service_discovery/cluster_services_controller.rb +++ b/app/controllers/provider/admin/service_discovery/cluster_services_controller.rb @@ -2,13 +2,20 @@ class Provider::Admin::ServiceDiscovery::ClusterServicesController < Provider::Admin::ServiceDiscovery::ClusterBaseController def index - render json: { services: cluster.discoverable_services(namespace: params.require(:namespace_id)).map(&:to_json) } + render json: cluster.discoverable_services(namespace: namespace_id).map(&:name) + .to_json end def show - cluster_service = cluster.find_discoverable_service_by(namespace: params.require(:namespace_id), name: params[:id]) + cluster_service = cluster.find_discoverable_service_by(namespace: namespace_id, name: params[:id]) render json: cluster_service.to_json rescue ::ServiceDiscovery::ClusterClient::ResourceNotFound => exception render_error exception.message, status: :not_found end + + private + + def namespace_id + params.require(:namespace_id) + end end diff --git a/app/javascript/src/NewService/components/FormElements/ErrorMessage.jsx b/app/javascript/src/NewService/components/FormElements/ErrorMessage.jsx index b6261419b6..1ce26b6e49 100644 --- a/app/javascript/src/NewService/components/FormElements/ErrorMessage.jsx +++ b/app/javascript/src/NewService/components/FormElements/ErrorMessage.jsx @@ -4,9 +4,11 @@ import React from 'react' const ErrorMessage = ({fetchErrorMessage}: { fetchErrorMessage: string -}) =>

- {`Sorry, your request has failed with the error: ${fetchErrorMessage}`} -

+}) => ( +

+ {`Sorry, your request has failed with the error: ${fetchErrorMessage}`} +

+) export { ErrorMessage diff --git a/app/javascript/src/NewService/components/FormElements/Select.jsx b/app/javascript/src/NewService/components/FormElements/Select.jsx index 808ff034f6..4105a01b56 100644 --- a/app/javascript/src/NewService/components/FormElements/Select.jsx +++ b/app/javascript/src/NewService/components/FormElements/Select.jsx @@ -2,34 +2,29 @@ import React from 'react' -type Option = { - metadata: { - name: string - } -} - type Props = { name: string, id: string, + disabled?: boolean, onChange?: (event: SyntheticEvent) => void, - options: Array