Add TimerTask #782
Add TimerTask #782
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| local timer_task = TimerTask.new(test_task) | ||
| local id = timer_task.id | ||
|
|
||
| timer_task = nil |
There was a problem hiding this comment.
value assigned to variable 'timer_task' is unused
| describe('when the task is active', function() | ||
| it('runs the task', function() | ||
| local timer_task = TimerTask.new(func, { args = args, interval = interval }) | ||
| local func_stub = stub(timer_task, 'task') |
There was a problem hiding this comment.
shadowing upvalue 'func_stub' on line 76
There was a problem hiding this comment.
Codeclimate does not update comments after initial review?
There was a problem hiding this comment.
Looks like it writes another comment without deleting the old one.
|
|
||
| describe(':execute', function() | ||
| local func = test_task | ||
| local func_stub |
| -- @tfield ?table args Arguments to the function | ||
| -- @tfield ?number interval Interval in seconds (defaults to 60) | ||
| function _M.new(task, options) | ||
| local options = options or {} |
There was a problem hiding this comment.
variable 'options' was previously defined as an argument on line 48
| describe('when the task is not active', function() | ||
| it('does not run the task', function() | ||
| local timer_task = TimerTask.new(func, { args = args, interval = interval }) | ||
| local func_stub = stub(timer_task, 'task') |
There was a problem hiding this comment.
shadowing upvalue 'func_stub' on line 76
| -- With __gc we can make sure that the task will stop scheduling more work | ||
| -- after it has been garbage collected. | ||
| local proxy = newproxy(true) | ||
| local mt = getmetatable(proxy) |
There was a problem hiding this comment.
shadowing upvalue 'mt' on line 32
| return self | ||
| end | ||
|
|
||
| local run_periodic, schedule_next, timer_execute |
There was a problem hiding this comment.
That is very weird style. Why not just define each function as local?
There was a problem hiding this comment.
I see. They all depend on each other so they need to be defined this way.
| run_periodic = function(self) | ||
| if not _M.task_is_active(self.id) then return end | ||
|
|
||
| self.task(unpack(self.args)) |
There was a problem hiding this comment.
Would be good to use 4a5a815 to make this safe.
There was a problem hiding this comment.
Yes, I can do that after resty.concurrent is merged.
This PR adds a new module that allows running periodic tasks that can be canceled.