Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[s2i] do not check ENV in run script #702

Merged
merged 1 commit into from
May 11, 2018
Merged

[s2i] do not check ENV in run script #702

merged 1 commit into from
May 11, 2018

Conversation

mikz
Copy link
Contributor

@mikz mikz commented May 11, 2018

Delegate all validation work to the Lua CLI.

@mikz
[s2i] do not check ENV in run script
8fce45b 
Delegate all validation work to the Lua CLI.
@mikz mikz force-pushed the entrypoint-env branch from 556c0a7 to 8fce45b Compare May 11, 2018 16:35
@mikz mikz requested a review from jmprusi May 11, 2018 16:35
jmprusi
jmprusi approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@jmprusi jmprusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@mikz mikz merged commit 356be50 into master May 11, 2018
@mikz mikz deleted the entrypoint-env branch May 11, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprusi jmprusi jmprusi approved these changes

@davidor davidor davidor approved these changes

Assignees

@mikz mikz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikz @davidor @jmprusi