Adapt rate limit config schema to make it compatible with react-jsonschema-form #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-jsonschema-form react-jsonschema-form is the library used by the 3scale UI.
davidor
force-pushed
the
adapt-rate-limit-policy-schema-to-react-jsonschema
branch
from
9e30b28
to
2b8a570
Compare
davidor
changed the title
mikz
pushed a commit
that referenced
this pull request
May 11, 2018
…-react-jsonschema Adapt rate limit config schema to make it compatible with react-jsonschema-form
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rate limit policy has a valid configuration JSON schema. However, it cannot be rendered by
react-jsonschema-formthe library used in the 3scale UI to build HTML forms from the config schemas.This PR solves the issue by adapting the schema. The library cannot render arrays of objects with different types, so I've split them into several arrays that have items of only one type. In particular, the properties causing issues in the UI library were
limitersanderror_settings.This is a breaking change, but not between final versions. If you were using this policy in a previous release candidate or beta, your configuration will become invalid.
Ref: #695