[THREESCALE-799] policy: document in schemas when the order in the chain matters #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
changed the title
davidor
force-pushed
the
clarify-order-in-schema-descriptions
branch
from
be42017 to
99d17ba
Compare
mikz
reviewed
Apr 23, 2018
| @@ -5,7 +5,9 @@ | |||
| "description": | |||
| ["This policy allows to modify the host of a request based on its path. ", | |||
| "It accepts regular expressions that, when matched against the path, ", | |||
| "replace it with a given string."], | |||
| "replace it with a given string. \n", | |||
| "When combined with the Apicast policy, the upstream policy should be ", | |||
There was a problem hiding this comment.
It should be spelled as APIcast policy:
https://github.com/3scale/apicast/blob/99d17ba34fa3ad7b461049b45e25a1088560d809/gateway/src/apicast/policy/apicast/apicast-policy.json#L3
Some policies only work properly when placed before or after the Apicast policy. Others have a different behavior depending on their position with respect to Apicast in the chain.
…order of policy chains
davidor
force-pushed
the
clarify-order-in-schema-descriptions
branch
from
99d17ba to
64e6195
Compare
mikz
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some policies only work properly when placed before or after the Apicast policy. Others have a different behavior depending on their position with respect to Apicast in the chain.
For the policies affected, this PR adds a clarification in the description of their schemas.
Ref: https://issues.jboss.org/browse/THREESCALE-799