Make caching policy work correctly when placed after apicast in the chain #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
force-pushed
the
export-cache-handler-caching-policy
branch
from
ccf94c2 to
98bcaef
Compare
Using rewrite() instead of export() causes problems when combining this policy with the apicast one. The reason is that the apicast policy uses the cache handler in its rewrite phase, and this policy sets it in the same phase. This means that currently, the caching policy only works when placed before the apicast policy in the chain. There's no reason why it should be that way, and setting the handler in export() instead of rewrite() should fix the issue.
davidor
force-pushed
the
export-cache-handler-caching-policy
branch
from
fed8f61 to
ef54de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671