Add option to never reload configuration when configuration loader is lazy #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to set keys without expiration in the cache setting the appropriate configs to -1 or anything < 0.
davidor
force-pushed
the
add-option-to-never-reload-lazy-mode
branch
from
56e275b
to
51568fa
Compare
mikz
reviewed
Apr 6, 2018
|
|
||
| store:add(service, -1) | ||
| -- Can't add stale info with config.add. Need to do it through the |
There was a problem hiding this comment.
We could add one with expiry 0 ?
There was a problem hiding this comment.
I just tried it and it does not work. I guess it needs a bit of time to delete it even with ttl=0.
mikz
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to use
APICAST_CONFIGURATION_LOADER=lazyand never refresh the configuration. This PR solves the issue by allowing setting negatives values inAPICAST_CONFIGURATION_CACHE.