Add JSON manifest for APIcast policy #601
Conversation
| "$schema": "http://apicast.io/policy-v1/schema#manifest#", | ||
| "name": "Apicast policy", | ||
| "description": "Main functionality of APIcast.", | ||
| "version": "0.1", |
There was a problem hiding this comment.
This can be tricky @mikz .
There was a problem hiding this comment.
I think we can have therebuiltin. The loaded already expects that for all builtin policies.
There was a problem hiding this comment.
I'm not sure about that. It's not a problem for now, but what if in the next release we introduce a new config param for this policy? We'd need to somehow distinguish the 2 versions.
There was a problem hiding this comment.
I mean it seriously needs to be builtin because those have different load path. It will not work at all with normal version string unless we move all policies to different folders.
I think it is fine because they are not released separately. We will have to maintain backwards compatibility.
Why we would need to distinguish two versions ? There is going to be just one version of APIcast policy. We could add some extra property to the policy API to show version of APIcast itself.
There was a problem hiding this comment.
I mean it seriously needs to be builtin because those have different load path. It will not work at all with normal version string unless we move all policies to different folders.
I think it is fine because they are not released separately. We will have to maintain backwards compatibility.
Why we would need to distinguish two versions ? There is going to be just one version of APIcast policy. We could add some extra property to the policy API to show version of APIcast itself.
Without a manifest, it will not show up in the policies endpoint.
davidor
force-pushed
the
apicast-policy-schema
branch
from
4ea2607 to
7d9bf80
Compare
Without a manifest, it will not show up in the policies endpoint.