[cli] load openresty libraries when rover is active #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
cli-openresty-lualib
branch
from
2a6e38a to
f334564
Compare
mikz
commented
Feb 15, 2018
gateway/bin/apicast
Outdated
| @@ -109,3 +109,61 @@ for my $inc ($apicast_src, 'src') { | |||
| my @args = ('resty', @resty_args, $bin, @ARGV); | |||
|
|
|||
| exec '/usr/bin/env', @args; | |||
|
|
|||
| __DATA__ | |||
There was a problem hiding this comment.
This is the easiest way to distribute the lua helper.
davidor
reviewed
Feb 15, 2018
gateway/bin/apicast
Outdated
| @@ -109,3 +109,61 @@ for my $inc ($apicast_src, 'src') { | |||
| my @args = ('resty', @resty_args, $bin, @ARGV); | |||
|
|
|||
| exec '/usr/bin/env', @args; | |||
|
|
|||
| __DATA__ | |||
| #!/usr/bin/env resty | |||
There was a problem hiding this comment.
I think we need an explanation here about why this is needed. Like the one included in the PR description.
There was a problem hiding this comment.
Added more comments. Most of them are in the lua helper code.
* when rover.setup is activated it strips out all paths other than lua_modules * openresty ships shared code in $prefix/lualib/ directory
mikz
force-pushed
the
cli-openresty-lualib
branch
from
f334564 to
68fc003
Compare
davidor
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rover would remove all shared paths, including paths
where openresty distributes own code.
So try go get those paths and set them back after loading rover.
It is not really possible to write a test because APIcast crashes in the CLI (before generating nginx config) and we have no CLI tests.