Extract MappingRule from Configuration #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
reviewed
Feb 2, 2018
| system_name = proxy_rule.metric_system_name or error('missing metric name of rule ' .. inspect(proxy_rule)), | ||
| delta = proxy_rule.delta | ||
| } | ||
| return mapping_rule.from_proxy_rule(proxy_rule) |
There was a problem hiding this comment.
This can be further simplified to map(mapping_rule.from_proxy_rule, proxy.proxy_rules or empty)
mikz
reviewed
Feb 2, 2018
gateway/src/apicast/mapping_rule.lua
Outdated
| return match | ||
| end | ||
|
|
||
| function _M.new(http_method, pattern, params, querystring_params, metric, delta) |
There was a problem hiding this comment.
I'd keep this method private because there is high chance the initializer will change with that many params.
There was a problem hiding this comment.
Good point. Let's wait until we bring more functionality from Service.
|
@davidor definitely agree! This is a good path to split the configuration.lua. The |
davidor
force-pushed
the
extract-mapping-rule
branch
from
6cf6e0d to
3d7f33e
Compare
There were many local methods in `Configuration` that were related only to mapping rules, so I think that this change makes sense. I think that some of the code from `Service` should also be in this new module, but let's go step by step.
davidor
force-pushed
the
extract-mapping-rule
branch
from
3d7f33e to
029e910
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactoring.
This PR extracts MappingRule from Configuration. There were many local methods in
Configurationthat were related only to mapping rules, so I think this makes sense.Just to be clear, there are no changes in the implementation nor the test coverage.
I think that some of the code from
Serviceshould also be in this new module, but let's go step by step.Let me know what you think @mikz . If you agree I'll add some documentation for the public methods.