policy/cors: stop setting headers twice in preflight reqs #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
force-pushed
the
set-headers-once-in-cors-preflight
branch
from
ade448b to
c3d9efc
Compare
davidor
commented
Feb 1, 2018
| @@ -72,9 +72,9 @@ local function is_cors_preflight() | |||
| ngx.var.http_access_control_request_method | |||
| end | |||
|
|
|||
| function _M:rewrite() | |||
| function _M.rewrite(_) | |||
There was a problem hiding this comment.
Changed this so codeclimate does not complain about unused self.
mikz
approved these changes
Feb 1, 2018
mayorova
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a minor improvement in the CORS policy.
In the case of a preflight request, we were setting the CORS headers twice. This PR fixes that.
Thanks @mayorova for reporting.