Extract rejection reason in Proxy instead of CacheHandler #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
approved these changes
Jan 5, 2018
davidor
force-pushed
the
resp-and-reject-reason-in-proxy
branch
from
19403f4 to
729b9b0
Compare
…che_handler Extracting the rejection reason and checking if the request has been authorized has nothing to do with the cache. We only need to check the response status and a header. This is why I'd rather not have this in the cache_handler module. Apart from that, this change will simplify the implementation of the caching policy.
Also stop checking whether the cache_handler methods return true or false, they no longer return that.
davidor
force-pushed
the
resp-and-reject-reason-in-proxy
branch
from
729b9b0 to
817c2d1
Compare
|
@mikz I added a changelog and fixed a minor codeclimate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting the rejection reason and checking if the request has been authorized has nothing to do with the cache. We only need to check the response status and a header. This is why I'd rather not have this in the cache_handler module.
Apart from that, this change will simplify the implementation of the caching policy.