[vagrant] use fedora 26 #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
Jan 8, 2018
gateway/bin/apicast
Outdated
| @@ -82,7 +82,9 @@ _LUA_ | |||
| $bin = $lua_file; | |||
| } | |||
|
|
|||
| my @resty_args = (); | |||
| my $nginx = $ENV{TEST_NGINX_BINARY} || $ENV{APICAST_OPENRESTY_BINARY} || 'openresty'; | |||
There was a problem hiding this comment.
Any reason why TEST_NGINX_BINARY has preference over APICAST_OPENRESTY_BINARY ?
We are doing the opposite in https://github.com/3scale/apicast/blob/25009f6e3f6029931066aa1c0737d70014a00570/gateway/src/apicast/cli/command/start.lua#L100
Also, it might be worth it to extract the method that selects the binary to a place where the cli and this bin can call it.
There was a problem hiding this comment.
Good point, will make it the same.
|
What's the reason to change from centos to fedora? Would be good to include in the commit or the PR description. |
|
@davidor updated the description. Main reason is outdated profiling toolchain on CentOS. |
* use rsync * install perl dependencies * install redis * use Fedora
so we can run against custom nginx binaries like openresty-asan
JSON::WebToken does not work with OpenSSL 1.1
davidor
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Vagrant box from CentOS to Fedora so we can use the latest tooling.
For development it makes sense to use latest profiling tooling like eBPF, perftools, SystemTap, ...
In centos all those tools are quite ancient because of the 3.11 kernel.