Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bin] start apicast when installed with rover #527

Merged
merged 2 commits into from
Dec 12, 2017
Merged

[bin] start apicast when installed with rover #527

merged 2 commits into from
Dec 12, 2017

Conversation

mikz
Copy link
Contributor

@mikz mikz commented Dec 11, 2017

  • cli now detects when being inside rover tree
    and starts with correct folders set up
  • remove old apicast-lua script

@mikz
[rockspec] install environment configurations
5249e45 
those were missing when installed from luarocks
@mikz mikz mentioned this pull request Dec 11, 2017
Merged
maneta
maneta approved these changes Dec 11, 2017
View reviewed changes
Copy link

@maneta maneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@mikz
[bin] apicast can be started when installed by rover
8e118e0 
improve the launcher script to detect when it is installed by rover
and start in the context of that installed version

replaces the existing apicast-lua
@mikz mikz requested a review from davidor December 12, 2017 10:03
@mikz mikz merged commit d8ddb6a into master Dec 12, 2017
@mikz mikz deleted the bin-luarocks branch December 12, 2017 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maneta maneta maneta approved these changes

@davidor davidor Awaiting requested review from davidor

Assignees

@mikz mikz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikz @maneta