Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] load apicast loader #525

Merged
merged 1 commit into from
Dec 11, 2017
Merged

[cli] load apicast loader #525

merged 1 commit into from
Dec 11, 2017

Conversation

mikz
Copy link
Contributor

@mikz mikz commented Dec 7, 2017

because the main APICAST_MODULE is loaded in the CLI
and it could have deprecated requires, we need to initialize the loader
that takes case of the deprecations

ERROR: ./src/apicast/policy_chain.lua:47: module apicast.module could not be loaded
stack traceback:
	./src/apicast/policy_chain.lua:47: in function 'build_default_chain'
	./src/apicast/policy/local_chain.lua:20: in main chunk
	[C]: in function 'require'
	./src/apicast/policy_chain.lua:76: in function 'load'
	./src/apicast/policy_chain.lua:47: in function 'default'
	./src/apicast/cli/environment.lua:57: in main chunk
	[C]: in function 'require'
	./src/apicast/cli/command/start.lua:12: in main chunk

because the main APICAST_MODULE is loaded in the CLI
and it could have deprecated requires, we need to initialize the loader
that takes case of the deprecations

```
ERROR: ./src/apicast/policy_chain.lua:47: module apicast.module could not be loaded
stack traceback:
	./src/apicast/policy_chain.lua:47: in function 'build_default_chain'
	./src/apicast/policy/local_chain.lua:20: in main chunk
	[C]: in function 'require'
	./src/apicast/policy_chain.lua:76: in function 'load'
	./src/apicast/policy_chain.lua:47: in function 'default'
	./src/apicast/cli/environment.lua:57: in main chunk
	[C]: in function 'require'
	./src/apicast/cli/command/start.lua:12: in main chunk
```
@mikz mikz force-pushed the cli-missing-apicast-loader branch from 8fd03c3 to 74f2e4c Compare December 7, 2017 17:05
@mikz mikz requested a review from davidor December 7, 2017 17:17
@davidor davidor merged commit b57d884 into master Dec 11, 2017
@davidor davidor deleted the cli-missing-apicast-loader branch December 11, 2017 09:30
mikz added a commit to 3scale/apicast-cloud-hosted that referenced this pull request Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants