Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] detect local rover installation #519

Merged
merged 1 commit into from
Dec 1, 2017
Merged

[cli] detect local rover installation #519

merged 1 commit into from
Dec 1, 2017

Conversation

mikz
Copy link
Contributor

@mikz mikz commented Nov 30, 2017 •
edited
Loading

to fix the rover detection on systems that don't have lua_modules/bin on the PATH

/cc @mayorova @kevprice83

@mayorova
Copy link
Contributor

mayorova commented Dec 1, 2017

This fixed the issue for me when bin/apicast was failing (nils where valid tables were expected), even though make dependencies competed successfully. It was only fixed when lua-rover was installed globally.

This PR makes APIcast work for me fine, without global lua-rover installation.

@mikz mikz merged commit aff4782 into master Dec 1, 2017
@mikz mikz deleted the lookup-local-rover branch December 1, 2017 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayorova mayorova mayorova approved these changes

@kevprice83 kevprice83 Awaiting requested review from kevprice83

Assignees

@mikz mikz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikz @mayorova