use new s2i-openresty with rover integration #460
Conversation
apicast/Roverfile.lock
Outdated
| ldoc 1.4.6-2 | ||
| liquid scm-1 | ||
| lua-resty-env 0.4.0-1 | ||
| lua-resty-execvp 0.1.0-1 |
There was a problem hiding this comment.
This needs to be updated. Those dependencies are not there yet.
because only apicast directory is uploaded to s2i image
.circleci/config.yml
Outdated
| @@ -7,7 +7,7 @@ jobs: | |||
| environment: | |||
| S2I_VERSION: "1.1.7-226afa1" | |||
| DOCKER_COMPOSE_VERSION: "1.16.1" | |||
| OPENRESTY_VERSION: "1.11.2.5-1" | |||
| OPENRESTY_VERSION: "rover" | |||
There was a problem hiding this comment.
A few lines below there's: quay.io/3scale/s2i-openresty-centos7:1.11.2.5-2. (Notice that the openresty version doesn't match 😱 )
Should it be adapted to use rover as well?
There was a problem hiding this comment.
Also, with this change, we'll no longer have documented the openresty version we are using.
Maybe we should use something like "rover-1.11.2.5-1" ?
There was a problem hiding this comment.
Yeah. I don't intend to merge it pointing to rover. After this is ready I'll merge the rover branch and do a new release of the s2i image with a correct version.
apicast/config-5.1.lua
Outdated
| @@ -0,0 +1,4 @@ | |||
| -- vim: set ft=lua: | |||
| rocks_trees = { | |||
There was a problem hiding this comment.
Can you add a comment explaining this?
mikz
force-pushed
the
rover
branch
2 times, most recently
from
016406d to
a48c2f4
Compare
workaround for luarocks/luarocks#740
* new rover integration 3scale/s2i-openresty#38 * builder and runtime images have the same path `/opt/app-root/src` * apicast can start without a prefix, using default openresty prefix
Extracted from #449
Use rover provided by 3scale/s2i-openresty#38
This change requires APIcast to start with a different prefix than the current source code because the directory is not writeable anymore.