don't call post action for oauth routes #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because there is just one instance of apicast module it can be used as global state but still thrown out when new instance is created in tests
for example oauth has own routes that can handle the request so there is no need to call post_action for them it should be called only when the access phase is evaluated
mikz
force-pushed
the
proxy-post_action-oauth
branch
from
1fe2a98
to
872b598
Compare
mpguerra
approved these changes
Mar 29, 2017
mayorova
reviewed
Mar 29, 2017
| local p = ngx.ctx.proxy or post_action_proxy[request_id] | ||
|
|
||
| post_action_proxy[request_id] = nil | ||
|
|
||
| if p then | ||
| p:post_action() | ||
| return p:post_action() | ||
| else | ||
| ngx.log(ngx.INFO, 'could not find proxy for request id: ', request_id) |
There was a problem hiding this comment.
This info message looks a bit alarming, like if it was supposed to find proxy, but couldn't, while most of the times it is absolutely fine and deliberate. Maybe say "skipping post_action, as no proxy was registered for the request id", and move it to DEBUG level?...
There was a problem hiding this comment.
Yeah I was thinking about that. INFO is first opt-in level so it is not shown by default.
I guess this should be part of some major log refactoring as there is lots of duplicated / too verbose information already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #299 (comment)