Some fixes / improvements for Keycloak integration #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
reviewed
Mar 17, 2017
apicast/src/configuration_loader.lua
Outdated
| @@ -128,7 +128,11 @@ end | |||
| function boot.init_worker(configuration) | |||
| local interval = ttl() or 0 | |||
|
|
|||
| configuration.keycloak = keycloak.load_configuration() | |||
| local keycloak_config = _M.run_external_command("keycloak") | |||
There was a problem hiding this comment.
We should move this to the .init function. init_worker is executed for each worker, but init just once.
There was a problem hiding this comment.
Yep, in fact it's already in the .init. I guess should be just removed from here, as Keycloak configuration is not something that will change with automatic reload. Right?
There was a problem hiding this comment.
And it is already loaded. Init_worker is executed right after. So it should be removed.
|
And of course, if this was broken there was no test so this should be covered by a new test. |
mayorova
changed the title
…INT environment variable is set
(fixes the issue with initial client options for ssl verification)
mayorova
force-pushed
the
fixes-keycloak
branch
from
910d007 to
10870e7
Compare
mayorova
changed the title
mikz
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with getting the configuration by Keycloak when running with
APICAST_CONFIGURATION_LOADER=boot.