ability to override backend endpoint from the configuration #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useful when deploying outside openshift cluster and want to use external Route over internal Service
parameter description should be nested in the list item
so the entrypoint test does not show any errors
thomasmaas
reviewed
Feb 6, 2017
|
|
||
| When `THREESCALE_PORTAL_ENDPOINT` environment variable is provided, the gateway will download the configuration from 3scale on initializing. The configuration includes all the settings provided on the Integration page of the API(s). | ||
|
|
||
| It is **required** to provide either `THREESCALE_PORTAL_ENDPOINT` or `THREESCALE_CONFIG_FILE` (takes precedence) for the gateway to run successfully. |
There was a problem hiding this comment.
it's becoming a bit chaotic in the overriding department. THREESCALE_CONFIG_FILE takes presedence over THREESCALE_PORTAL_ENDPOINT. BACKEND_ENDPOINT_OVERRIDE overrides backend endpoint from ENV
There was a problem hiding this comment.
Well they are two unrelated things. Loading config has own order: file, v2 api, v1 api .
And this just overrides backend endpoint of any configuration loaded.
There was a problem hiding this comment.
And later this will be refactored into one configuration option that will accept urls like:
file:///path/some/where/config.jsonhttps://user:[email protected]https://user:[email protected]/archive/config.json
thomasmaas
approved these changes
Feb 6, 2017
|
Looks good to me (and works). |
mayorova
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes the configuration can point to internal service that is not accessible from outside
for that we would like to have the ability to override backend endpoint with some env variable
the new variable name is
BACKEND_ENDPOINT_OVERRIDEand expects an url likehttp://backend.example.com.