get config from the v2 api #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
lazy-load-configuration
branch
6 times, most recently
from
c0faeec to
38a7c41
Compare
mikz
force-pushed
the
lazy-load-configuration
branch
from
38a7c41 to
3505031
Compare
mikz
force-pushed
the
lazy-load-configuration
branch
5 times, most recently
from
b55d26e to
8808f88
Compare
mikz
force-pushed
the
lazy-load-configuration
branch
from
8808f88 to
9d7cb72
Compare
mikz
changed the title
mikz
force-pushed
the
lazy-load-configuration
branch
from
573b63a to
cfe8929
Compare
APItools/monitor#10 APItools had quite advanced http client with custom backends and async requests. I hope to take that as a base to create smart http client that would understand caching and authentication. But also having custom backends would make it much easier to test and stub responses. [http_ng] cleanup the code to not use globals [http_ng] pass the luacheck linter
definitely not finished, does not do any path normalization
mikz
force-pushed
the
lazy-load-configuration
branch
from
c0c408d to
bbad8d5
Compare
when the expectation does not match it prints the key and the values
so you can have global headers for example
mikz
force-pushed
the
lazy-load-configuration
branch
2 times, most recently
from
8fd6ea2 to
8cda4e8
Compare
mikz
force-pushed
the
lazy-load-configuration
branch
from
8cda4e8 to
e2bb5ad
Compare
they are useless for the balancer until we support SRV
when they are added to the configuration
mayorova
reviewed
Jan 16, 2017
| @@ -531,7 +531,33 @@ all ok | |||
| --- error_log | |||
| host foo for service 2 already defined by service 1 | |||
|
|
|||
| === TEST 12: return headers with debugging info | |||
| === TEST 12: print message that service was added to the configuration | |||
| Including it's host so it is easy to see that configuration was loaded. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration environments (staging/production) using new API.
The API looks like:
That allows us to have new ENV variable
THREESCALE_DEPLOYMENT_ENVto control from which environment to load the configuration. Right now it issandbox(possibly renamed in the future) orproduction.It is using HTTP client from APItools project. It supports fake backend/ stubbing in tests which makes it really useful even though it is quite big and would deserve some refactoring. Eventually it should be extracted into own project.
TODO