Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(notebook): fix cluster inference command and improve cluster training command #93

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Conversation

chitsanfei
Copy link
Contributor

Specially thanks to your repo and It's very helpful to me. I made small changes on your repo which may make colab notebook work in a better way. Here's what I changed.

Modifications

Feasible modifications may be better to fix #92. Mainly in colab notebook.

PS

  • Code need be revised, and highly recommended to merge in a new dev branch.

@chitsanfei chitsanfei closed this Mar 24, 2023
@34j
Copy link
Collaborator

34j commented Mar 24, 2023

Please wait for #94 to be resolved as I want to fix it all at once.

@chitsanfei chitsanfei reopened this Mar 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #93 (90f95a6) into main (07920a4) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   16.93%   16.93%           
=======================================
  Files          28       28           
  Lines        3365     3365           
  Branches      388      388           
=======================================
  Hits          570      570           
  Misses       2784     2784           
  Partials       11       11           
Impacted Files Coverage Δ
src/so_vits_svc_fork/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@34j 34j changed the title docs(notebook): Improve the design of cluster training and conference. docs(notebook): improve the design of cluster training and conference. Mar 24, 2023
notebooks/so-vits-svc-fork-4.0.ipynb Outdated Show resolved Hide resolved
notebooks/so-vits-svc-fork-4.0.ipynb Outdated Show resolved Hide resolved
notebooks/so-vits-svc-fork-4.0.ipynb Show resolved Hide resolved
Copy link
Contributor Author

@chitsanfei chitsanfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"!svc train-cluster --output-path drive/MyDrive/so-vits-svc-fork/logs/44k/kmeans.pt"
Let user decide on themselves about their kmeans file name and not to set a default filename may prevent some users who do not understand the meaning of exceptions from using it. In my opinion, It can make the project more acceptable to people and reduce feedback on ineffective issues.
All in all, it depends on you, you could delete it in the future commit. 😊

@chitsanfei chitsanfei requested a review from 34j March 24, 2023 04:12
@34j 34j changed the title docs(notebook): improve the design of cluster training and conference. docs(notebook): fix cluster inference command and improve cluster training command Mar 24, 2023
@34j 34j merged commit 7642594 into voicepaw:main Mar 24, 2023
@34j
Copy link
Collaborator

34j commented Mar 24, 2023

@allcontributors add MashiroSA docs, bug

@allcontributors
Copy link
Contributor

@34j

I've put up a pull request to add @MashiroSA! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(notebook)-issue: Some possible issues in colab notebook of #84.
3 participants