-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(notebook): fix cluster inference command and improve cluster training command #93
Conversation
Please wait for #94 to be resolved as I want to fix it all at once. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 16.93% 16.93%
=======================================
Files 28 28
Lines 3365 3365
Branches 388 388
=======================================
Hits 570 570
Misses 2784 2784
Partials 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"!svc train-cluster --output-path drive/MyDrive/so-vits-svc-fork/logs/44k/kmeans.pt"
Let user decide on themselves about their kmeans file name and not to set a default filename may prevent some users who do not understand the meaning of exceptions from using it. In my opinion, It can make the project more acceptable to people and reduce feedback on ineffective issues.
All in all, it depends on you, you could delete it in the future commit. 😊
@allcontributors add MashiroSA docs, bug |
I've put up a pull request to add @MashiroSA! 🎉 |
Specially thanks to your repo and It's very helpful to me. I made small changes on your repo which may make colab notebook work in a better way. Here's what I changed.
Modifications
Feasible modifications may be better to fix #92. Mainly in colab notebook.
PS