Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(train): fix check for notebook / Colab #335

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

Lordmau5
Copy link
Collaborator

It seems the is_notebook check was inverted here, which causes the fancy RichProgressBar to not show up locally (or in that case, actually supported places)

This might also fix #321

@34j 34j merged commit 7f69814 into voicepaw:main Apr 15, 2023
@outhipped
Copy link

Can you please link the colab in which this issue was fixed? Thanks.

@Lordmau5
Copy link
Collaborator Author

Can you please link the colab in which this issue was fixed? Thanks.

My understanding is that you should be able to run the update command in any of the Colab's again
(pip install -U so-vits-svc-fork)
and it should be fixed in them. This shouldn't be for just a single colab

@outhipped
Copy link

outhipped commented Apr 15, 2023 via email

@Lordmau5 Lordmau5 deleted the fix/progressbar branch April 15, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colab: Training steps / epochs not appearing on log, only D_0.pth and G_0.pth being created
3 participants