Replies: 28 comments 11 replies
-
Yeah i have recieved the same notification on my antivirus, can someone review the changes why the file is being detected? |
Beta Was this translation helpful? Give feedback.
-
it seems i am not alone, i got the same virus type, strange because yesterday i played without any warning |
Beta Was this translation helpful? Give feedback.
-
also, we got a response for the file creator earlier on his own post So yeah, if you guys don't want to use the file anyways, we need to stick at 60 fps for now |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
@tuanminh26596 yeah i appreciate it too, it's nice to have someone like him supporting the comunity, but the only reason i don't let any file that gets a warning in my system it's because i suffered a lot with trojans back then, i think it's a valid point |
Beta Was this translation helpful? Give feedback.
-
I've tried building the project myself and Windows Defender still tripped over the executable Visual Studio spat out. So yeah, it's some virus scanner heuristic that's resulting in a false positive. I'm not much of a C++ dev myself otherwise it'd be interesting to dive in to see if there's a workaround to avoid the trigger. |
Beta Was this translation helpful? Give feedback.
-
Have to play Genshin at 60 fps on a 2k 164hz monitor is a torture 💀 |
Beta Was this translation helpful? Give feedback.
-
I also built it myself and it worked for some reason. Microsoft isn't detecting it. |
Beta Was this translation helpful? Give feedback.
-
yes, please fix |
Beta Was this translation helpful? Give feedback.
-
Looking at the PR to 4.3 update I expect this line in the vcxproj file to be the issue: At least I don't see any other changes that the program wasn't doing already before. Perhaps someone could make a branch and test it. Make a PR if it works. I don't have the tools installed on my PC (not going to use my work laptop for this). |
Beta Was this translation helpful? Give feedback.
-
EDIT: I only sent the link to Virustotal, which doesnt work properly, as @Vindfury pointed out. My bad
I tried the same, downloaded Visual Studio 2022, built the source code and scanned it with Windows Defender and Malwarebytes. No detection. Am using the self-built now |
Beta Was this translation helpful? Give feedback.
-
Porbably the problem is that Win Def is really picky. |
Beta Was this translation helpful? Give feedback.
-
Unfortunately, scanning via the download link doesn't work. You need to upload it yourself for VirusTotal to show actual results. I'm curious if you got the same 'size_t' to 'DWORD' warning when you compiled it yourself. For reference this is what you'll get from VirusTotal if you upload the GitHub exe And this is what I got when I compiled it myself Maybe you can also check your build if you don't mind uploading yours to VirusTotal as well |
Beta Was this translation helpful? Give feedback.
-
If I recall correctly, the detection started happening with the v2.1.2 release. I stuck with v2.1.1 because it was working fine for 4.2 anyway |
Beta Was this translation helpful? Give feedback.
-
@Vindfury here is the one I built from source-code. Detections are the same as yours. I updated my previous comment Im gonna try and build the previous versions |
Beta Was this translation helpful? Give feedback.
-
@MenonPlayz Thank you! I appreciate it and yeah, I saw your updated post |
Beta Was this translation helpful? Give feedback.
-
Hello. 7 hours ago today I received the same error. I tried to reinstall everything and I still get the Windows Defender alert. Hopefully the creator of an explanation or a patch to solve this quickly. I want to enjoy the new event at 120fps :( |
Beta Was this translation helpful? Give feedback.
-
i have the same "issue" but as the dev said, it's a false positive. You have the same issue with cheatengine for example (windows defender and some other Anti Virus said it's a trojan/malware) but if you download from a trust source there's no problem. But again you can built in yourself but if i've read correctly even this trigger some Anti-Virus. I choose to trust the dev. |
Beta Was this translation helpful? Give feedback.
-
Okay, I built everything since the May 29 commit "try to fix unlocker not working on first boot" The VirusTotal links for my self compiled May 29, November 17 commit, December 6, December 7, December 16, December 17 - 1, December 17 - 2 and December 19 aka latest commit builds seem to show the same detections. None get detected by Microsoft Defender (both on my PC and in VirusTotal, I manually selected and scanned all of the exes). I dont know a lot about malware, am new to C++ and new to this unlocker. So I can only give my findings to y'all |
Beta Was this translation helpful? Give feedback.
-
Excuse me, can you give me a small class on how to compile from Visual Studio so I can use it in official Genshin? I am 100% new to programming |
Beta Was this translation helpful? Give feedback.
-
I don't buy it. Why would a personally compiled version of the same exe ring up with so many less positives than the author compiled version? |
Beta Was this translation helpful? Give feedback.
-
Some tips for anyone else struggling with this. I installed Visual Studio 2019 CE as instructed for compiling by the dev. I then took the 2.1.1 source (last version which didn't give any Defender trojan warnings) and implemented all the FPS detection logic from the latest 2.2.0 version, but didn't include RequireAdministrator in unlockfps_clr.vcxproj This still gave me warnings if uploaded to Virustotal, but on my PC this stopped Defender from complaining. Scanning it manually doesn't give anything malicous either. I do have to run the exe manually as admin or toggle it from file properties, but so far it has worked for 3 days straight with no trojan warnings. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Thank you MenonPlayz. I followed your instructions and it worked for me. The only thing I wasn't c;lear on but found the information on within Visual Studio was where the new .exe file after Building Solution was. Like you mentioned, it was in the x64>Debug folder, and those folders were located in the original .sln file folder location. |
Beta Was this translation helpful? Give feedback.
-
Ihave no idea about program but I can build exe thanks to your tip and GPT. |
Beta Was this translation helpful? Give feedback.
-
It still gets tagged on VirusTotal aswell: https://www.virustotal.com/gui/file/08f16aa2f37dcd7fb4748c360a12f17e1fef33906be4cb8586874237af6f5fec/detection EDIT: Althought that does look a lot like false positives and went from 3 flags to 2 flags. The remaining 2 flags are both AI. |
Beta Was this translation helpful? Give feedback.
-
Microsoft Defender has detected this file as a virus
Beta Was this translation helpful? Give feedback.
All reactions