Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy action to also be triggered by changes to workflow files #583

Merged
merged 3 commits into from
Aug 6, 2021

Conversation

sgibson91
Copy link
Member

We may want to update this to specify only changes the deploy-hubs.yaml. I'm not sure what is gained if we trigger on changes to, say, python-lint.yaml?

@yuvipanda
Copy link
Member

Makes sense to restrict it to just that file. Do we still use a separate action file? If so we should include that too.

@sgibson91
Copy link
Member Author

Makes sense to restrict it to just that file. Do we still use a separate action file? If so we should include that too.

Yes we do, will add that

@yuvipanda
Copy link
Member

Thanks, @sgibson91! I've hit approve, so merge whenever you think you can look at the deploys?

@sgibson91
Copy link
Member Author

Thanks! Will probably be tomorrow morning for me now :)

@yuvipanda
Copy link
Member

@sgibson91 yay! I am very happy with how the review process in this worked for me :)

@yuvipanda
Copy link
Member

I often find it slightly awkward to merge PRs because what if they broke deployment? Now that i"m just reviewing and not deploying, it's much easier to commit :D

@sgibson91 sgibson91 merged commit e5769c0 into 2i2c-org:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants